✨[Feat] Sprint 2 JPEG Container Parser - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnostics
JPEG_INVALID_SOI, JPEG_INVALID_MARKER, JPEG_TRUNCATED_MARKER, JPEG_TRUNCATED_SEGMENT_LENGTH, JPEG_INVALID_SEGMENT_LENGTH, JPEG_TRUNCATED_SEGMENT, JPEG_TRUNCATED_SCAN, JPEG_MISSING_EOI, JPEG_SEGMENT_LIMIT_EXCEEDED, and JPEG_TRAILING_DATA.
Tests
Deferred
No TIFF/EXIF/GPS field decoding, XMP XML parsing, IPTC/ICC reconstruction, thumbnail or image decoding, entropy/Huffman decoding, JPEG rewriting or cleaning, PNG/WebP parsing, fuzzing, Rust, or WASM is included.
Validation
Security review
All JPEG reads use ByteReader. Declared lengths are fully range-checked before subtraction or offset addition. Every parser loop advances or returns. APP signatures are constrained to payload boundaries, scan data is not copied or decoded, inputs are not mutated, and no runtime network, filesystem, DOM, or Node dependency is introduced.